Discussion:
[nebula-dev] Help about a bug
Laurent Caron
2018-11-13 20:34:03 UTC
Permalink
Good evening,

I tried to work on bug 534362 [1]. Currently there are source jars for all
Nebula widgets in the release, except for all the newly added Opal widgets.

I've checked the pom.xml but I've no idea of how this problem can be solved.

Do you have any idea ?


Laurent

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=534362
Jonah Graham
2018-11-13 21:23:18 UTC
Permalink
Hi Laurent,

I believe you are missing the bit of magic in each feature.xml file. By
having a bundle with .source suffix referenced in the feature.xml, tycho
automatically will create it for you (using the tycho-source-plugin
<https://www.eclipse.org/tycho/sitedocs/tycho-source-plugin/plugin-source-mojo.html>,
as configured in the pom.xml
<https://github.com/eclipse/nebula/blob/feb083fdce31046311af8485db432b72ae3ea6c9/releng/org.eclipse.nebula.nebula-parent/pom.xml#L152>).
For example:

$ git diff -U15
diff --git
a/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
b/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
index 99f4e00e..3e7a9f4a 100644
---
a/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
+++
b/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
@@ -12,16 +12,23 @@
<license url="%licenseURL">
%license
</license>

<requires>
<import feature="org.eclipse.nebula.widgets.opal.commons.feature"/>
</requires>

<plugin
id="org.eclipse.nebula.widgets.opal.breadcrumb"
download-size="0"
install-size="0"
version="0.0.0"
unpack="false"/>

+ <plugin
+ id="org.eclipse.nebula.widgets.opal.breadcrumb.source"
+ download-size="0"
+ install-size="0"
+ version="0.0.0"
+ unpack="false"/>
+
</feature>


Now you just need to repeat that for each feature.xml.

HTH
Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
Post by Laurent Caron
Good evening,
I tried to work on bug 534362 [1]. Currently there are source jars for all
Nebula widgets in the release, except for all the newly added Opal widgets.
I've checked the pom.xml but I've no idea of how this problem can be solved.
Do you have any idea ?
Laurent
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=534362
_______________________________________________
nebula-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/nebula-dev
Laurent Caron
2018-11-13 21:48:01 UTC
Permalink
Hi Jonah,

Well I missed it completely :)

Thank you very much, I just have to update my 27 feature.xml files...

Have a nice evening,

Laurent
Post by Jonah Graham
Hi Laurent,
I believe you are missing the bit of magic in each feature.xml file. By
having a bundle with .source suffix referenced in the feature.xml, tycho
automatically will create it for you (using the tycho-source-plugin
<https://www.eclipse.org/tycho/sitedocs/tycho-source-plugin/plugin-source-mojo.html>,
as configured in the pom.xml
<https://github.com/eclipse/nebula/blob/feb083fdce31046311af8485db432b72ae3ea6c9/releng/org.eclipse.nebula.nebula-parent/pom.xml#L152>).
$ git diff -U15
diff --git
a/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
b/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
index 99f4e00e..3e7a9f4a 100644
---
a/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
+++
b/widgets/opal/breadcrumb/org.eclipse.nebula.widgets.opal.breadcrumb.feature/feature.xml
@@ -12,16 +12,23 @@
<license url="%licenseURL">
%license
</license>
<requires>
<import feature="org.eclipse.nebula.widgets.opal.commons.feature"/>
</requires>
<plugin
id="org.eclipse.nebula.widgets.opal.breadcrumb"
download-size="0"
install-size="0"
version="0.0.0"
unpack="false"/>
+ <plugin
+ id="org.eclipse.nebula.widgets.opal.breadcrumb.source"
+ download-size="0"
+ install-size="0"
+ version="0.0.0"
+ unpack="false"/>
+
</feature>
Now you just need to repeat that for each feature.xml.
HTH
Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
Post by Laurent Caron
Good evening,
I tried to work on bug 534362 [1]. Currently there are source jars for
all Nebula widgets in the release, except for all the newly added Opal
widgets.
I've checked the pom.xml but I've no idea of how this problem can be solved.
Do you have any idea ?
Laurent
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=534362
_______________________________________________
nebula-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________
nebula-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/nebula-dev
Continue reading on narkive:
Loading...